As my mentor Wyclif had reviewed the first week code changes for the 'select object types to validation' feature and have added his comments on the code I spent this week to modify the code according to the feedback and improving it.
The main three points to do improvement were,
1. In the object types selection dialog window, show the Simple Object type name instead of showing the full class name as org.openmrs.Concept etc. So with the new changes these types are changes to;
org.openmrs.Concept --> Concept
org.openmrs.Provider --> Provider etc.
2. Instead of string processing to get the selected types to be posted once the list is submitted, use Spring and send a List of types.
After i set the name of the checkboxes to be the same i.e type, then the browser always sends all checked ones to the server and spring automatically convert them into a list or array. Therefore i changed the previous way of reading the types and append them into a single send before it is posted and used this method.
3. Reviewed on the logic which makes validation threads and tested whether it works fine.
The main three points to do improvement were,
1. In the object types selection dialog window, show the Simple Object type name instead of showing the full class name as org.openmrs.Concept etc. So with the new changes these types are changes to;
org.openmrs.Concept --> Concept
org.openmrs.Provider --> Provider etc.
2. Instead of string processing to get the selected types to be posted once the list is submitted, use Spring and send a List of types.
After i set the name of the checkboxes to be the same i.e type, then the browser always sends all checked ones to the server and spring automatically convert them into a list or array. Therefore i changed the previous way of reading the types and append them into a single send before it is posted and used this method.
3. Reviewed on the logic which makes validation threads and tested whether it works fine.
No comments:
Post a Comment